fix(BA-693): Failure of whole image rescanning when there is a misconfigured container registry #3652
+115
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jopemachine
changed the title
github-actions
bot
added
comp:manager
github-actions
bot
added
size:S
jopemachine
force-pushed
the
fix_whole_image_rescan_fail_when_misconfigured_registry_row_exist
branch
from
f45646d to
da9135b
Compare
jopemachine
changed the title
jopemachine
changed the title
jopemachine
changed the title
github-actions
bot
added
comp:client
Comment on lines
+72
to
+78
| BgtaskEvents = ( | ||
| BgtaskUpdatedEvent | ||
| | BgtaskDoneEvent | ||
| | BgtaskCancelledEvent | ||
| | BgtaskFailedEvent | ||
| | BgtaskIssueReportedEvent | ||
| ) |
There was a problem hiding this comment.
In my opinion, it seems better to create a PartialSuccessEvent. Instead, for compatibility purposes, Please set the event.name value to bgtask_done and change it together with the frontend work later on.
Comment on lines
+398
to
+409
| issues = [] | ||
| if event_cls is BgtaskDoneEvent: | ||
| tracker_key = f"bgtask.{task_id}" | ||
| raw_errors_str = await redis_helper.execute( | ||
| redis_producer, lambda r: r.hget(tracker_key, "issues") | ||
| ) | ||
| if raw_errors_str: | ||
| try: | ||
| issues = json.loads(raw_errors_str) | ||
| except Exception: | ||
| log.error("Failed to parse bgtask errors from the Redis") | ||
| issues = [raw_errors_str] |
There was a problem hiding this comment.
In my opinion, it seems that an event should be created and passed through the try-catch in wrapper_task.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3650, #3700 (BA-693, BA-753).
Checklist: (if applicable)